Patch notes is a nice idea, I'm going to redo the options page soon so I'll work that into it
Mod Slayer's post is broken before it's even quoted.
The thing is viewing the source in a browser only displays the browsers interpretation of the page. It doesn't show the original code that's served from the domain. What we see is the code after the browser has attempted to correct errors, thus viewing source doesn't always give an accurate picture of what's going on.
What's happening is Mod Slayer's sig is wrapping around and including the quote button. This goes against typical page layout and RS Linkify can get thrown out by this. Simply the page content isn't what's expected.
Here's the actual code before the browser gets it.
http://puu.sh/6g2gP.png
My problem is I can't handle all the broken code Jmod submit on these forums. The amount of poorly coded jmod signatures is widespread. I have offered to fix them but they aren't interested.
Since the HTML is rarely closed properly I'd have to make a guess where it starts and ends, this would not be perfect and would cause other issues.
I have actually played around with Jmod sigs and got them to render correctly in quotes, however it only works if there are no errors or if I know in advance what the errors are. If someone knows a one size fits all solution I'm happy to give it a try but in this example RS Linkify wouldn't remove the HTML becasue it reads as though the reply button is in there.
Here's how chrome interprets the page and applies it's own guess at what the code should be.
http://puu.sh/6fZzS.png
In this case chrome added closing tags and removes some stuff but it can only guess at what the author intended. End result is errors are patched but the page isn't the way it's meant to be. It would be so much simpler if they just got the very basics right.
TL
R: I've sacked people for less.
10-Jan-2014 14:34:32
- Last edited on
10-Jan-2014 17:43:01
by
Indecent Act
Don't view source within the browser. Dump the source via ajax, that way you don't get modifications made by the browser. It can be quite an eye opener.
I just went to the page that Keighlea linked me to, opened console and pasted my generic source viewing code. I use this lots, it's very handy and at least you get the true picture.
var xhr = new XMLHttpRequest();
xhr.open("GET", document.URL, false);
xhr.onload = function () {
if (xhr.readyState === 4) {
if (xhr.status === 200) {
console.log(xhr.responseText);
}
}
};
xhr.send(null);
10-Jan-2014 15:12:32
- Last edited on
10-Jan-2014 15:19:58
by
Indecent Act
I'm back to bother you more, but I bring a peace offering! -sets down the coffee pot and backs away slowly-
You said... At some point, on some thread, that you're able to use the t= thing on youtube videos, and when linkify embeds it it'll play from that point. That's never worked for me
... For example, this video,