forums.rs

Forums

RS-Linkify Thread is sticky

Quick find code: 261-262-33-65181208

of 1105
Indecent Act

Indecent Act

Posts: 7,456 Rune Posts by user Forum Profile RuneMetrics Profile
Update: Version 3.1.3.6

- Delay has been restored to header bar menus
- I've made the forum link in header link to the forums rather than non existent page
- Titles and Display names are the same colour (may change depending on feedback)
- Some other minor colouring issues have been fixed
- Scroll to top and bottom has been adjusted
- Custom avatars in the reply area should be working again.

Some thing I'm not sure about...

I haven't touched the custom avatar for the top left in the header, not all custom avatars will fit in the circle since some are square. I'm not sure what I'll do.

Amaethwr said :


• Using the refresh button at the bottom of the thread causes the final positioning to be off a little. For example on this thread (at 5350 posts), I end up with: HTTP://puu.sh/bAaZO.png
E: This doesn't happen on page 536 at the moment, maybe its due to images or the Twitter embedding?

• For some reason, on page 536, you have 2 icons beneath your avatar:
HTTP://puu.sh/bAd8C.png This seems to be inconsistent, and when hovering the mouse over the RS-Linkify one, gives the 'Gold Premier Club Member' message.


The page alignment is out when things change the height of the page after the page loaded. Images (slower loading ones)and  twitter embedding are the main culprits though. Nothing I can do about that since the size of those things is unknown until after they have been embedded.

As for the two icons appearing under my name, I cant tell if that's still occurring. My main concern is if it's happening to people who are both the author of a thread and are using god icons. I haven't seen this as yet.

­­­­

Big thanks again to everyone who's posted since the forum update. Sadly this forum update (like most others) doesn't seem to have offered any improvements or features. I really wouldn't mind if an update took some of the load off Linkify...

maybe one day :)

16-Sep-2014 05:17:24

Amaethwr
Aug Member 2008

Amaethwr

Posts: 14,634 Opal Posts by user Forum Profile RuneMetrics Profile
Thanks :) I'll keep an eye out for that with the icons beneath avatars and let you know if I see it anywhere. As I said, it was inconsistent, so it might be hard to reproduce as such.

E: (While I wish I did have this title in this colour..) Custom titles don't show next to the reply box at the bottom and on the 'Edit a message' page. Can't remember if it was the same way before or not, so mentioning it just in case. :P

http://puu.sh/bB2lB.png
Selective Completionist

16-Sep-2014 06:24:54 - Last edited on 16-Sep-2014 06:50:43 by Amaethwr

Indecent Act

Indecent Act

Posts: 7,456 Rune Posts by user Forum Profile RuneMetrics Profile
Always a pleasure NayR :)

Thanks Amaethwr, you've been an awesome help ­<3

I just did a another update, I usually make stuff like this optional, but sometimes some things just require immediate action.

This is what version 3.1.3.7 does...

HTTP://puu.sh/bB2lG.jpg

I don't expect to get too many complaints about it, and if I do well that's just a shame because it's staying that way.

I really found it distracting. I want my eye drawn to the content within the forums, no where else.

Edit:

I can't remember if custom titles did show next to the reply box. I have a feeling they didn't but I might be wrong. It's something I will do though.

I know titles show in preview, but for some reason the positioning is all messed up and I never bothered with that. I might work on that too, it's nice to have everything consistent.

16-Sep-2014 06:53:13 - Last edited on 16-Sep-2014 07:06:29 by Indecent Act

Dsctatom
Dec Member 2023

Dsctatom

Posts: 12,987 Opal Posts by user Forum Profile RuneMetrics Profile
I borrowed your method for jquery ajax injection; this will fix the number shown online (current_id needs to be replaced with your current session id):

main = "function player_count() {$.ajax({type: 'GET',url: 'http://www.runescape.com/c=" + current_id + "/player_count.js?varname=iPlayerCount',async: true,contentType: 'application/json',dataType: 'jsonp',success: function(iPlayerCount){ if (iPlayerCount > 0 ){iPlayerCount=String(iPlayerCount); document.getElementById('playerCount').innerHTML = (iPlayerCount.length > 3) ? iPlayerCount.substring(0,iPlayerCount.length-3) + ',' + iPlayerCount.substring(iPlayerCount.length-3) : iPlayerCount;}}});setTimeout(player_count,3000)};player_count()";
script = document.createElement('script');
script.appendChild(document.createTextNode(main));
document.head.appendChild(script);
script.parentNode.removeChild(script);

16-Sep-2014 07:35:40

Ryan M
May Member 2008

Ryan M

Posts: 3,095 Adamant Posts by user Forum Profile RuneMetrics Profile
Indecent Act said :
I can't remember if custom titles did show next to the reply box. I have a feeling they didn't but I might be wrong. It's something I will do though.
They didn't appear below the display name if they appeared at all going by pictures I have. They either appeared below the avatar as they do in the preview screen or not at all. It's nice to have consistency with anchors as the off color for visited links was a little odd.

I think you can make the custom images work in the header-top__player-avatar by just pushing the image down 3px and max-width and max-height 22px. Although there might be one or two people who appear to cut into the border radius until max of 20px and down 4px.

Another way to make it work at the default 25px is to remove the border radius. Or you could try to make the Figure have priority over the img, but it's probably more of a hassle than it's worth.
http://puu.sh/bB4KL/2524e8ba39.png

16-Sep-2014 07:59:03

Indecent Act

Indecent Act

Posts: 7,456 Rune Posts by user Forum Profile RuneMetrics Profile
@Dsctatom,

hehe I'm glad and honoured you like my injection script (love it when people build on my work).

I actually wrote that to get around same domain origin policy. JQuery Ajax for the jsonp and good old vanilla JS for the injection. This is only needed for sandbox environments like content scripts since the jsonp callback gets sent to the page and not to the routine that called it.

I searched the web for ages looking for a simple method, but none worked and this the best I could come up with. Kind of hacky but technically nothing wrong with it.

I was going to wait and see if they were going to fix the player count, but since you posted a nice fix I might do this soon :)


@Ryan M,

thanks for that. I haven't really looked at the avatar at the top left. As you can imagine it's not been a priority during the last 24 hours. However you have given me a place a start so I might take a look it soon.

Also thanks for confirming about the titles in the quick reply area. My memory might not be as bad as I thought :)

16-Sep-2014 08:03:25 - Last edited on 16-Sep-2014 08:12:33 by Indecent Act

Dsctatom
Dec Member 2023

Dsctatom

Posts: 12,987 Opal Posts by user Forum Profile RuneMetrics Profile
I searched earlier today and came to the same conclusion. After all attempts failed, I realized you must've done something to bypass it.

I just finished getting my Bestiary fix working again. Some of the things they do (and especially don't do) are just sad. It's more of a quick hack than a beautiful addition, but it works:

http://puu.sh/bB6BH/d5e6ba3642.jpg

Edit: I just realized Jagex refers to his walking as "crawl" despite "walk" being a standard method they use on other creatures (like the flying Arboretum guard).

16-Sep-2014 08:43:20 - Last edited on 16-Sep-2014 08:46:03 by Dsctatom

Indecent Act

Indecent Act

Posts: 7,456 Rune Posts by user Forum Profile RuneMetrics Profile
You're a brave man attempting to work on Bestiary. Looks like you are doing well though.

I just threw your player count routine into my extension and it's running perfectly.

The only thing I did was increase the duration between calls. That's not because of anything you did. I never like the way those scripts persist. It doesn't take long for the resources tab in the console to filled with 100's of them.

I don't even know if it's a bad thing or not, the V8 javascript engine has very good garbage collection but I suspect there maybe something more to this. It's only runescpae pages where I've seen scripts accumulate under resources to point of 1000's.

Anyway I'll push out an update shortly (going to run it a while and have dinner first), and if you have no objections I'd like to credit you for your help :)

16-Sep-2014 08:55:46

Quick find code: 261-262-33-65181208 Back to Top