You made a post about music, but I've seen surprisingly little about one of the most important parts! Actually composing it! If music actually becomes a skill I'd like to be able to actually play my own instrument instead of just following premade songs. I was actually thinking about making a post about that, but I saw this one and decided to say this here instead.
The other day I was bored in my coding class so I skipped ahead to the bit concerning music.
It had a function called playNote that -believe it or not- let you play a note. You had to include 3 numbers with the function: one for the note to be played, another for how long the note was to be held, and another for the intensity with which it was played. The function ended up looking something like this.
playNote(57,210,127)
playNote(62,190,126)
playNote(57,200,125)
playNote(64,200,124)
playNote(57,200,123)
playNote(60,200,127)
playNote(62,200,127)
playNote(57,200,127)
playNote(65,200,127)
playNote(57,200,127)
playNote(67,200,127)
playNote(57,200,127)
playNote(64,200,127)
playNote(65,200,127)
playNote(57,200,127)
playNote(62,200,127)
(60 is middle C with each number moving it up or down a half step,200 is in milliseconds, 127 was an average intensity)
Players could write notes like this onto a sheet or something in game and then have their avatar play out the music for them to hear.
If it ends up being a skill you could also link song length to music level, like 5-10 notes per music level. I don't really like the idea of limiting notes played, but it might be a good way to give incentive to level up.
I'd love to see this added in so I could walk around and hear all the player written songs. I really think it's something that would add some magic to this game. Also, sorry if this was a little rambly. This idea makes me excited and forum posts make me nervous.