Forums

RS-Linkify Thread is sticky

Quick find code: 261-262-33-65181208

Ryan M
May Member 2008

Ryan M

Posts: 3,095 Adamant Posts by user Forum Profile RuneMetrics Profile
Just noticed something odd. Trying to see if the Twitch code is now making hyperlinks below a Twitch channel link no longer be read properly.

Also just learned that doing the normal spoiler makes twitch links clickable instead of placing them in a spoiler button. I don't think it needs it, just was interesting to see. :)

http://example.com

http://www.twitch.tv/runescape/c/5147925

http://example.com

My Version Info...


RS-Linkify Version: 3.1.5.2
Chrome Version: 38.0.2125.58
Compiled for: Win32
Language: en-US
OS: Windows NT 6.3; Win64; x64
Blood Caffeine Level: 45% Caffeine, 55% Blood. (Not quite awake yet.)


Edit: Seems that somehow the ' str_tmp ' is not allowing Linkify to continue looking for hyperlinks. Of course if you're linking to a channel you'll get a 404 from Twitch if it's not a past broadcast. However I don't see how it's preventing it from working as intended. All I can say at the moment is that Twitch.tv is making me Twitch.now. :@

Edit 2: Well it would seem that the variable should be ' str_tmp2 ' rather than ' str_tmp ' because ' mystr '. ;)

23-Sep-2014 22:50:03 - Last edited on 23-Sep-2014 23:57:31 by Ryan M

Stephano

Stephano

Posts: 4,444 Adamant Posts by user Forum Profile RuneMetrics Profile
I've always loved Sirenic. Please and thank you!
http://puu.sh/bLoe6/a0e66598f7.jpg

*EDIT* I made the image with a transparent background, hopefully that makes it thru*

24-Sep-2014 01:51:59 - Last edited on 24-Sep-2014 01:52:45 by Stephano

Indecent Act

Indecent Act

Posts: 7,456 Rune Posts by user Forum Profile RuneMetrics Profile
Wow Ryan M,

How on earth did you even make sense of that gibberish. All those recycled vars get really ugly very quickly. I'm uploading a fix at this very moment.

Nicely picked up with the link below the vid, and even more nicely picked up with the solution :)

Makes me glad I haven't minified all my code, not sure if my comments are much use. I guess you know what's going better than I do, you probably don't need the commenting.

Big thank you, your help is just amazing and very much appreciated ­<3


(laughing as I type this) Oh I found a little issue with the twitch embedding the other day. Yay for me fixing something before someone else did :)

24-Sep-2014 01:55:40

Ryan M
May Member 2008

Ryan M

Posts: 3,095 Adamant Posts by user Forum Profile RuneMetrics Profile
Always happy to help. Minification isn't as bad when reading versus trying to read regular expressions you (myself) wrote a year ago. I pretty much know what I'm going to look for. Solving them just takes time and constant breaking things to find the culprit. I figured something about the Twitch block changed at some point. :)

Comments are best to be sparse. The only comments I try to leave are reminders to remove lines/blocks when Chrome releases a fix or it's the GNU General Public License statement. Sometimes I feel people just need to be pushed in the right direction. :P

On a related note, Notepad++ might not be the end all, but it certainly helps. ;)
HTTPS://i.imgur.com/CIzweKj.png

Edit: Looked at the Forum Stats, only 94 posts were highlighted by Linkify users in the past 28 days. That's absurdly low, even though there is only one option to highlight stuff under. Thought that was interesting. :O

By the way, I wouldn't have noticed the link issue had it not been that the Twitter link I had in a previous post on this thread was not working like it should have. Probably would have never seen the issue otherwise because how many people link to Twitch at this moment? Anyhow, it's always nice to have someone finding things.

And I just noticed the credits page. Somehow it makes me think I knocked off Daezhun. All well, it's always good fun even if the bugs aren't. :P

This image comes to mind when thinking of Daezhun though:
https://i.imgur.com/2dVmq6P.png

PS. https://www.dropbox.com/sh/3hd3vskqv4zpdkl/r64eTbjIE9/?lst
Something you might want from the old FS forum as the post no longer exists.

24-Sep-2014 02:24:58 - Last edited on 24-Sep-2014 02:58:23 by Ryan M

Indecent Act

Indecent Act

Posts: 7,456 Rune Posts by user Forum Profile RuneMetrics Profile
Oh sweet, thanks for the link :)

I did minify RS Linkify until I realised some people were looking over my code. I figure if people are looking at it, I might as well make it readable. Oh I use notepad++. But often I do little things from work and I just use notepad when I'm there.

Nice pic of Mod Daezhun! I miss him. He was great value, and he was very supportive of RS Linkify. Also very helpful in many other ways too. I was sad to see him go.

Edit: Thread highlighting is quite low considering the page views. Not a bad thing considering that one option for highlighting is pretty serious.

Eventually (when I have collected more data) I'd like to put some graphs up spanning a few months, or ideally spanning a year. I'd like to see a visual representation of how forum activity relates to updates and events in Runescape.

24-Sep-2014 03:58:35 - Last edited on 24-Sep-2014 04:14:07 by Indecent Act

Quick find code: 261-262-33-65181208 Back to Top